Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dnceng/internal/dotnet-optimization #86436

Merged
merged 8 commits into from
May 22, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 18, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.SourceLink.GitHub: from 8.0.0-beta.23252.2 to 8.0.0-beta.23218.3 (parent: Microsoft.DotNet.Arcade.Sdk)
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23263.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Subscription: d3a5b203-1393-4534-5b62-08d8d8feb47e
  • Build: 20230521.4
  • Date Produced: May 22, 2023 6:20:28 AM UTC
  • Commit: 85af145192ce699ffcc16bd1a7b565820b6a2dff
  • Branch: refs/heads/main

…otnet-optimization build 20230517.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23267.3

Dependency coherency updates

Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
 From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23218.3 (parent: Microsoft.DotNet.Arcade.Sdk
@lewing lewing requested a review from oleksandr-didyk May 18, 2023 18:13
@lewing
Copy link
Member

lewing commented May 18, 2023

cc @dotnet/source-build-contrib

@MichaelSimons
Copy link
Member

@oleksandr-didyk please take a look at the prebuilts. Why were the sourcelink and xliff-tasks versions incoherent with arcade and where do the prebuilts come from?

@oleksandr-didyk
Copy link
Contributor

@oleksandr-didyk please take a look at the prebuilts. Why were the sourcelink and xliff-tasks versions incoherent with arcade and where do the prebuilts come from?

The pre-builts appear since they are dependencies from the referenced version of Arcade, i.e. they were coherent before this change.

I have no idea why Maestro did this downgrade nor can I reproduce it locally. I'll try asking around, but for now it seems just reverting the downgrade would solve the pre-builts

…otnet-optimization build 20230518.7

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23268.7
dotnet-maestro bot and others added 3 commits May 20, 2023 12:10
…otnet-optimization build 20230519.15

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23269.15
…otnet-optimization build 20230520.4

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23270.4
@sbomer
Copy link
Member

sbomer commented May 21, 2023

With the latest updates this is getting the new profile data format produced by https://dev.azure.com/dnceng/internal/_git/dotnet-optimization/pullrequest/31410. As expected, the innerloop build was failing with:

error: Could not read profile /__w/1/s/.packages/optimization.linux-x64.pgo.coreclr/1.0.0-prerelease.23270.4/data/coreclr.profdata: unsupported instrumentation profile format version

I pushed a fix for #85785 that should unblock this. @janvorli @jkoritzinsky PTAL.

dotnet-maestro bot and others added 2 commits May 22, 2023 12:09
…otnet-optimization build 20230521.4

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23271.4
@sbomer
Copy link
Member

sbomer commented May 22, 2023

I tried reverting the coherency downgrades as suggested in #86436 (comment).

@sbomer sbomer merged commit 7dc82a5 into main May 22, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-6aa59be6-b3d5-402a-92ed-59e5d061ac94 branch May 22, 2023 21:05
@ghost ghost locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants