-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dnceng/internal/dotnet-optimization #86436
Conversation
…otnet-optimization build 20230517.3 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23267.3 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23218.3 (parent: Microsoft.DotNet.Arcade.Sdk
cc @dotnet/source-build-contrib |
@oleksandr-didyk please take a look at the prebuilts. Why were the sourcelink and xliff-tasks versions incoherent with arcade and where do the prebuilts come from? |
The pre-builts appear since they are dependencies from the referenced version of Arcade, i.e. they were coherent before this change. I have no idea why Maestro did this downgrade nor can I reproduce it locally. I'll try asking around, but for now it seems just reverting the downgrade would solve the pre-builts |
…otnet-optimization build 20230518.7 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23268.7
…otnet-optimization build 20230519.15 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23269.15
…otnet-optimization build 20230520.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23270.4
With the latest updates this is getting the new profile data format produced by https://dev.azure.com/dnceng/internal/_git/dotnet-optimization/pullrequest/31410. As expected, the innerloop build was failing with:
I pushed a fix for #85785 that should unblock this. @janvorli @jkoritzinsky PTAL. |
…otnet-optimization build 20230521.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23260.3 -> To Version 1.0.0-prerelease.23271.4
I tried reverting the coherency downgrades as suggested in #86436 (comment). |
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization