[browser] Turn webcil off for .NET < 8.0 #86505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
This was referenced May 19, 2023
maraf
commented
May 22, 2023
| @@ -170,7 +172,9 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <_WasmCopyOutputSymbolsToOutputDirectory Condition="'$(_WasmCopyOutputSymbolsToOutputDirectory)'==''">true</_WasmCopyOutputSymbolsToOutputDirectory> | |||
| <_WasmEnableThreads>$(WasmEnableThreads)</_WasmEnableThreads> | |||
| <_WasmEnableThreads Condition="'$(_WasmEnableThreads)' == ''">false</_WasmEnableThreads> | |||
|
|
|||
| <_WasmEnableWebcil>$(WasmEnableWebcil)</_WasmEnableWebcil> | |||
There was a problem hiding this comment.
Do we want to explicitly log error when user sets the property and targets unsupported version?
There was a problem hiding this comment.
We'll discuss this further, because there isn't any such condition although there are features are supported only in some versions
lambdageek
approved these changes
May 22, 2023
|
Failures are unrelated |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webcil is supported only on .NET >= 8.0, but the SDK bits are shared also with .NET 6 and 7.