Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing assemblyref for typeref only kept for debug info in illink #87575

Merged
merged 5 commits into from
Jun 16, 2023

Commits on Jun 12, 2023

  1. Configuration menu
    Copy the full SHA
    ceb41a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Correct typerefs referenced from debug info

    When linking `save` assemblis with `-b true` (linking debug info), we preserve
    all debug info (and don't sweep the debug info like we do for `link` assemblies).
    
    With this change, we now take into account type references that are only referenced
    by the debug info, preserving any assembly refs needed by them.
    
    This adds test infra to walk the type references in the output assembly, and
    check that they reference assembly refs that also exist in the output.
    
    Includes some test infra changes that were ultimately not necessary for the repro,
    but were useful, to allow passing multiple additional compiler args when compiling
    testcase dependencies.
    sbomer committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    73bc051 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3dbe1e8 View commit details
    Browse the repository at this point in the history
  3. Revert exit code checking test infra

    This should be adequately covered by NoLinkedOutputAttribute
    sbomer committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1a90728 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    cd9f4a8 View commit details
    Browse the repository at this point in the history