[mono] Precompute the CallInfo structure used by the mono_arch_..nati… #88369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
BrzVlad,
kotlarmilos,
lambdageek and
SamMonoRT
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
This speeds up ves_pinvoke_method () in the interpreter, including the icalls which use QCallTypeHandle. |
…ve_call_context_.. functions.
vargaz
force-pushed
the
native-call-context
branch
from
2c05979
to
74f0f53
Compare
BrzVlad
reviewed
Jul 4, 2023
| if (!call_info) { | ||
| call_info = mono_arch_get_interp_native_call_info (get_default_mem_manager (), sig); | ||
| mono_memory_barrier (); | ||
| *cache = call_info; |
There was a problem hiding this comment.
We should use a CAS here to avoid leaks from races
There was a problem hiding this comment.
The memory is allocated from the mem manager, so its going to be leaked anyway.
There was a problem hiding this comment.
I see. Also a mono_memory_write_barrier here is enough.
BrzVlad
reviewed
Jul 4, 2023
BrzVlad
reviewed
Jul 4, 2023
BrzVlad
reviewed
Jul 4, 2023
|
This speeds up this testcase by about 50% when running with the interpreter: |
danmoseley
added
area-VM-meta-mono
and removed
needs-area-label
lewing
approved these changes
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ve_call_context_.. functions.