[wasm] Browser.targets: Fix .dlls being deployed to publish/
#96045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned IL-linked dlls get copied to the `publish/` directory when using AOT. This is because in `ProcessPublishFilesForWasm` target the `ResolvedFileToPublish` item ends with a copy of the original .dll files, even though they should be replaced with what was received from the nested publish.
…t better behavior with anti-viruses
radical
force-pushed
the
fix-blazor-publish
branch
from
80454d1 to
af9344e
Compare
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIL-linked dlls get copied to the
|
ilonatommy
approved these changes
Dec 19, 2023
|
this improved the size a lot :-) 
should it be back ported to NET8 or was the issue present only in the main? |
This was referenced Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IL-linked dlls get copied to the
publish/directory when using AOT. This is because inProcessPublishFilesForWasmtarget theResolvedFileToPublishitem ends with a copy of the original .dll files, even though they should be replaced with what was received from the nested publish.