Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 encodings for IF_SVE_AT_3A to IF_SVE_BK_3A #97082

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Jan 17, 2024

None of these instructions use a predicate to mask the result.

Some of these are unpredicated versions of existing instructions. For these we need new sopt values. Once we can distinguish between V0 and P0 then these sopt entries can be removed.

corecltr output (identical to capstone)

add z0.b, z0.b, z0.b
sqadd z3.h, z31.h, z12.h
sqsub z7.s, z0.s, z31.s
sub z19.d, z7.d, z13.d
uqadd z23.b, z28.b, z29.b
uqsub z31.h, z31.h, z31.h
index z24.b, wzr, w9
index z12.d, x15, x0
mul z5.b, z0.b, z31.b
smulh z0.h, z31.h, z5.h
umulh z31.d, z5.d, z0.d
sqdmulh z7.b, z28.b, z0.b
sqrdmulh z23.h, z3.h, z31.h
asr z9.b, z31.b, z2.d
lsl z19.h, z0.h, z12.d
lsr z29.s, z10.s, z22.d
ftssel z17.d, z16.d, z15.d

Contributes towards #94549.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 17, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 17, 2024
@ghost
Copy link

ghost commented Jan 17, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

None of these instructions use a predicate to mask the result.

Some of these are unpredicated versions of existing instructions. For these we need new sopt values. Once we can distinguish between V0 and P0 then these sopt entries can be removed.

corecltr output (identical to capstone)

add z0.b, z0.b, z0.b
sqadd z3.h, z31.h, z12.h
sqsub z7.s, z0.s, z31.s
sub z19.d, z7.d, z13.d
uqadd z23.b, z28.b, z29.b
uqsub z31.h, z31.h, z31.h
index z24.b, wzr, w9
index z12.d, x15, x0
mul z5.b, z0.b, z31.b
smulh z0.h, z31.h, z5.h
umulh z31.d, z5.d, z0.d
sqdmulh z7.b, z28.b, z0.b
sqrdmulh z23.h, z3.h, z31.h
asr z9.b, z31.b, z2.d
lsl z19.h, z0.h, z12.d
lsr z29.s, z10.s, z22.d
ftssel z17.d, z16.d, z15.d
Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@a74nh
Copy link
Contributor Author

a74nh commented Jan 17, 2024

@kunalspathak

@kunalspathak
Copy link
Member

@dotnet/arm64-contrib

@a74nh
Copy link
Contributor Author

a74nh commented Jan 18, 2024

Build error looks unrelated.

@BruceForstall BruceForstall merged commit 72dc71d into dotnet:main Jan 18, 2024
127 of 129 checks passed
@a74nh a74nh deleted the IF_SVE_AT_3A_github branch January 19, 2024 10:39
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants