Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageOverrides.txt is not parsed correctly #10904

Open
ericstj opened this issue Mar 18, 2020 · 2 comments
Open

PackageOverrides.txt is not parsed correctly #10904

ericstj opened this issue Mar 18, 2020 · 2 comments
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Mar 18, 2020

See:

private TaskItem CreatePackageOverride(string runtimeFrameworkName, string packageOverridesPath)
{
TaskItem packageOverride = new TaskItem(runtimeFrameworkName);
packageOverride.SetMetadata("OverriddenPackages", File.ReadAllText(packageOverridesPath));
return packageOverride;
}

This reads the entire contents of the file and sets it as metadata.

This creates a problem, because the consumption of the PackageOverrides assumes delimited packages, and the task is not inserting delimiters.

See #2937 (comment)

To fix this the task should either insert the delimiters, or we should change the file to append a semi-colon after every package ID.

@ericstj
Copy link
Member Author

ericstj commented Mar 18, 2020

/cc @dsplaisted @dagood

@dagood
Copy link
Member

dagood commented Mar 18, 2020

/cc @NikolaMilosavljevic FYI

@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Apr 6, 2020
@wli3 wli3 removed the untriaged Request triage from a team member label Apr 8, 2020
@wli3 wli3 added this to the 5.0.1xx milestone Apr 8, 2020
@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Apr 16, 2020
@wli3 wli3 removed the untriaged Request triage from a team member label Apr 20, 2020
@wli3 wli3 modified the milestones: 5.0.1xx, Backlog Apr 20, 2020
@wli3 wli3 removed their assignment Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants