Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Source Link, Generators, and custom props/targets to work with WPF in 5.x #15395

Closed
clairernovotny opened this issue Jan 19, 2021 · 4 comments
Assignees
Labels
Area-NetSDK untriaged Request triage from a team member
Milestone

Comments

@clairernovotny
Copy link
Member

clairernovotny commented Jan 19, 2021

There were two issues fixed in WPF for 6.0 that were just back-ported to 5.0.2/5.0.3 behind an opt-in flag. It's opt-in with WPF as they can't differentiate between runtime and SDK.

The SDK (5.0.200/300) needs to enable this property by default so PackageReferences and custom BaseIntermediateOutputPath fully work in WPF. This will unblock Generators, Source Link, and any other NuGet package that contains custom props/targets in it.

IncludePackageReferencesDuringMarkupCompilation should be set to true by the SDK if undefined by the user code.

These are the PR's to 5.0 servicing containing the fixes we want to enable in the SDK
dotnet/wpf#4009
dotnet/wpf#3846

This will resolve the following issues:
dotnet/wpf#810
dotnet/wpf#3404
dotnet/wpf#1718

Likely this one too: dotnet/wpf#366

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jan 19, 2021
@clairernovotny
Copy link
Member Author

@tmat @jaredpar

@jaredpar
Copy link
Member

@marcpopMSFT wanted to make sure that you saw this issue. This impacts some division goals around Terrapin and we're really hoping we can get it in for 16.9. The work should be small, just setting a few defaults in WPF projects. But time is getting short in 16.9 so wanted to make sure this hadn't slipped below your radar.

@sfoslund
Copy link
Member

Fixed in 5.0.2xx by #15465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

5 participants