Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy for runtime pack authors to enable linker trimming analyzer #49124

Open
marek-safar opened this issue Feb 19, 2021 · 12 comments
Open

Comments

@marek-safar
Copy link
Contributor

The runtime pack SDKs authors will be the first non-runtime users with who we could work to enable linker trimming analysis warning. We should make it easy for them to enable it in their builds and not require copying pieces from https://github.com/dotnet/runtime/blob/master/src/libraries/illink-sharedframework.targets to figure out how to use linker in their runtime pack builds.

This would be best to behave this available as part of Arcade target.

@agocke @sbomer @vitek-karas

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 4, 2021
@marek-safar marek-safar transferred this issue from dotnet/sdk Mar 4, 2021
@ghost
Copy link

ghost commented Mar 4, 2021

Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik
See info in area-owners.md if you want to be subscribed.

Issue Details

The runtime pack SDKs authors will be the first non-runtime users with who we could work to enable linker trimming analysis warning. We should make it easy for them to enable it in their builds and not require copying pieces from https://github.com/dotnet/runtime/blob/master/src/libraries/illink-sharedframework.targets to figure out how to use linker in their runtime pack builds.

This would be best to behave this available as part of Arcade target.

@agocke @sbomer @vitek-karas

Author: marek-safar
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged

Milestone: -

@ViktorHofer
Copy link
Member

The runtime pack SDKs authors

Curious, who are runtime pack SDK authors? How would they build targeting and runtime packs? Via the Shared Framework SDK which lives in Arcade?

@vitek-karas
Copy link
Member

Curious, who are runtime pack SDK authors?

Xamarin, Blazor, ...

@marek-safar
Copy link
Contributor Author

How would they build targeting and runtime packs

They are already building them and have already or could have access to Arcade

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 4, 2021

They are already building them

IMHO every shared framework SDK author should use https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.SharedFramework.Sdk. That's the tooling that implements the shared framework contract (ie PlatformManifest, FrameworkList, etc). Curious, can you please let us know who are the teams (and people that we can talk to) that already build custom shared frameworks to make sure that they use the common tooling?

Implementing trimming on top of the shared framework SDK should be relatively easy.

@marek-safar
Copy link
Contributor Author

can you please let us know who are the teams

@ViktorHofer for the main shared framework with trimming support now use the following contacts

@ViktorHofer
Copy link
Member

Thanks Marek. I will start an offline discussion to make sure that people are aware of the Shared Framework SDK that lives in arcade.

@ViktorHofer
Copy link
Member

Based on the discussion I believe what this issue tracks is:

  1. Add linking feature to the shared framework
  2. Add linking analyzer feature to the shared framework

Does that make sense?

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Mar 24, 2021
@ViktorHofer ViktorHofer added this to the Future milestone Mar 24, 2021
@ViktorHofer ViktorHofer modified the milestones: Future, 6.0.0 Mar 24, 2021
@marek-safar
Copy link
Contributor Author

@ViktorHofer I don't know if we want to add them to shared framework, it should probably go to the arcade as we already ship the tooling with SDK.

@ViktorHofer ViktorHofer modified the milestones: 6.0.0, 7.0.0 Aug 4, 2021
@carlossanlop
Copy link
Member

@marek-safar should we move this to 8.0?

@ViktorHofer ViktorHofer modified the milestones: 7.0.0, Future Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants