-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easy for runtime pack authors to enable linker trimming analyzer #49124
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik Issue DetailsThe runtime pack SDKs authors will be the first non-runtime users with who we could work to enable linker trimming analysis warning. We should make it easy for them to enable it in their builds and not require copying pieces from https://github.com/dotnet/runtime/blob/master/src/libraries/illink-sharedframework.targets to figure out how to use linker in their runtime pack builds. This would be best to behave this available as part of Arcade target.
|
Curious, who are runtime pack SDK authors? How would they build targeting and runtime packs? Via the Shared Framework SDK which lives in Arcade? |
Xamarin, Blazor, ... |
They are already building them and have already or could have access to Arcade |
IMHO every shared framework SDK author should use https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.SharedFramework.Sdk. That's the tooling that implements the shared framework contract (ie PlatformManifest, FrameworkList, etc). Curious, can you please let us know who are the teams (and people that we can talk to) that already build custom shared frameworks to make sure that they use the common tooling? Implementing trimming on top of the shared framework SDK should be relatively easy. |
@ViktorHofer for the main shared framework with trimming support now use the following contacts
|
Thanks Marek. I will start an offline discussion to make sure that people are aware of the Shared Framework SDK that lives in arcade. |
Based on the discussion I believe what this issue tracks is:
Does that make sense? |
@ViktorHofer I don't know if we want to add them to shared framework, it should probably go to the arcade as we already ship the tooling with SDK. |
@marek-safar should we move this to 8.0? |
The runtime pack SDKs authors will be the first non-runtime users with who we could work to enable linker trimming analysis warning. We should make it easy for them to enable it in their builds and not require copying pieces from https://github.com/dotnet/runtime/blob/master/src/libraries/illink-sharedframework.targets to figure out how to use linker in their runtime pack builds.
This would be best to behave this available as part of Arcade target.
@agocke @sbomer @vitek-karas
The text was updated successfully, but these errors were encountered: