Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Microsoft.DotNet.Watcher.Tests.GlobbingAppTests.RenameCompiledFile and DeleteSourceFolder #42921

Open
baronfel opened this issue Aug 21, 2024 · 1 comment
Labels
Area-Watch Test Debt untriaged Request triage from a team member

Comments

@baronfel
Copy link
Member

baronfel commented Aug 21, 2024

Describe the bug

I disabled these tests as part of #42240 after they failed repeatedly in CI despite working locally on Windows and Linux systems. We should figure out what's up and re-enable them. The fix that worked for the remaining GlobbingAppTests that didn't need to be skipped was to strip Terminal Logger ANSI codes from the stdout of the app being run via dotnet run so that the simple string-based equality checks being done in the tests would work, but those do in fact work locally.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Aug 21, 2024
@baronfel baronfel changed the title Re-enable Microsoft.DotNet.Watcher.Tests.GlobbingAppTests.RenameCompiledFile Re-enable Microsoft.DotNet.Watcher.Tests.GlobbingAppTests.RenameCompiledFile and DeleteSourceFolder Aug 22, 2024
@tmat
Copy link
Member

tmat commented Aug 26, 2024

Test output for investigation:
console.20a7f859.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Watch Test Debt untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants