Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behavior for the commands that require nuget.org #44312

Closed
marcpopMSFT opened this issue Oct 18, 2024 · 0 comments
Closed

Change default behavior for the commands that require nuget.org #44312

marcpopMSFT opened this issue Oct 18, 2024 · 0 comments

Comments

@marcpopMSFT
Copy link
Member

We have nuget.org hardcoded into a couple of our commands. Those commands are not common but it's possible a customer could end up running them in a scenario where they don't have nuget.org configured in their nuget.config and don't want us skipping past that configuration.

I would argue a better experience would be a customer runs dotnet tool search and we report back that the command is only supported on nuget.org and the customer should update their nuget configuration if they want to continue. That seems more reasonable than doing the network query when their configuration doesn't include it.

sdk/src/Cli/dotnet/NugetSearch/NugetToolSearchApiRequest.cs at main · dotnet/sdk (github.com)
This appears to always hit nuget.org when running a tool search.

sdk/src/Cli/Microsoft.TemplateEngine.Cli/TemplatePackageCoordinator.cs at main · dotnet/sdk (github.com)
This seems to be the same command as the below one depending on whether it's a local package or not.
if (localPackage != null && packageTemplates != null)

sdk/src/Cli/Microsoft.TemplateEngine.Cli/NuGet/NugetApiManager.cs at main · dotnet/sdk (github.com)
This one will add nuget.org if the sourcefeed passed in is null. It's called from DisplayTemplatePackageMetadata which is used in the "dotnet new details command".

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NuGet untriaged Request triage from a team member labels Oct 18, 2024
@baronfel baronfel reopened this Oct 19, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Oct 19, 2024
@nagilson nagilson added needs team triage Requires a full team discussion and removed untriaged Request triage from a team member labels Nov 12, 2024
@marcpopMSFT marcpopMSFT added this to the 10.0.1xx milestone Nov 12, 2024
@marcpopMSFT marcpopMSFT removed the needs team triage Requires a full team discussion label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants