[Aspire]: dotnet watch kills process tree on windows and does not let DCP cleanup containers

[davidfowl]

CTRL+C on windows I haven't verified non-windows, shuts down the process tree including dcp which does not allow it to properly clean up containers. This means that running watch and using Ctrl + C leaves containers running (a leak).

I made an app using:

dotnet new aspire-starter --use-redis-cache -o DemoApp

watchungraceful.mp4

[davidfowl]

This still reproduces with 9.0.200-preview.0.24551.17+aea7b5075c8933b1c6d7ac59d40a7cabb0da6af1, which is after the fix was made.

[davidfowl]

cc @karolz-ms

[karolz-ms]

I thought @tmat had a fix for this... allowing DCP escape from the job dotnet watch sets up (setting JOB_OBJECT_LIMIT_BREAKAWAY_OK on it)

[tmat]

I don't have a fix. What exactly should dotnet-watch do? We are launching the project using dotnet run. dotnet-watch does not create the actual app process.

[karolz-ms]

OK. Last time I checked, DCP launched via dotnet watch (on Windows) was part of a Job that had had JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE flag set somewhere in the SDK. And then when the ProcessReaper https://github.com/dotnet/sdk/blob/main/src/Cli/Microsoft.DotNet.Cli.Utils/ProcessReaper.cs deletes that job, all the processes inside it get killed cold.

So the ask is to change the SDK to set JOB_OBJECT_LIMIT_BREAKAWAY_OK on that Job, so that DCP can "break away" and regain control over its destiny. Maybe as an opt-in that dotnet watch would use.

[davidfowl]

@baronfel can you help with the investigation here?