Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CheckTargetFrameworkDisplayName often fails in CI #45148

Open
tmat opened this issue Nov 26, 2024 · 0 comments
Open

Test CheckTargetFrameworkDisplayName often fails in CI #45148

tmat opened this issue Nov 26, 2024 · 0 comments
Labels
Test Debt untriaged Request triage from a team member
Milestone

Comments

@tmat
Copy link
Member

tmat commented Nov 26, 2024

The test reads redirected std output, which ends up garbled.

 result.StdOut.StripTerminalLoggerProgressIndicators().Should().BeEquivalentTo(expectedFrameworkDisplayName);

Fails with message:

Expected string to be equivalent to ".NET Standard 2.1" with a length of 17, but "�[1F
.NET Standard 2.1" has a length of 23, differs near "�[1" (index 0).

Seems like StripTerminalLoggerProgressIndicators is not reliable. We should consider disabling the progress indicators when running in test environment rather than stripping them from the output.

Test disabled by #44899

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Nov 26, 2024
@marcpopMSFT marcpopMSFT added this to the 10.0.1xx milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Debt untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

3 participants