Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/windowsdesktop #45376

Closed
wants to merge 10 commits into from
Closed

[main] Update dependencies from dotnet/windowsdesktop #45376

wants to merge 10 commits into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 9, 2024 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Sdk.WindowsDesktop: from 10.0.0-alpha.1.24605.3 to 10.0.0-alpha.1.24612.1 (parent: Microsoft.WindowsDesktop.App.Ref)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 10.0.0-alpha.1.24605.2 to 10.0.0-alpha.1.24612.3 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 10.0.0-alpha.1.24605.3 to 10.0.0-alpha.1.24612.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

From https://github.com/dotnet/windowsdesktop

  • Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
  • Build: 20241217.1
  • Date Produced: December 17, 2024 2:00:35 PM UTC
  • Commit: f65fe32c33bde09ad153053205809bb17ec3d4f7
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
6788977 
…ld 20241209.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24609.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 10.0.0-alpha.1.24605.3 -> To Version 10.0.0-alpha.1.24609.2 (parent: Microsoft.WindowsDesktop.App.Ref
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Dec 9, 2024
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

dotnet-maestro bot commented Dec 9, 2024

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

This was referenced Dec 9, 2024
Open
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
bc092e3 
…ld 20241209.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24609.2
@v-wuzhai
Copy link
Member

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Dec 10, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
78ad4a0 
…ld 20241210.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24610.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 10.0.0-alpha.1.24605.3 -> To Version 10.0.0-alpha.1.24610.1 (parent: Microsoft.WindowsDesktop.App.Ref
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
bc52f5d 
…ld 20241210.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24610.2
@v-wuzhai
Copy link
Member

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

dotnet-maestro bot and others added 2 commits December 12, 2024 14:16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
72660a4 
…ld 20241212.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24612.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 10.0.0-alpha.1.24605.3 -> To Version 10.0.0-alpha.1.24610.4 (parent: Microsoft.WindowsDesktop.App.Ref
@dsplaisted
Update TFM folder for WindowsDesktop crossgen
4b44eec
@dsplaisted
Copy link
Member

@dotnet/wpf-developers @singhashish-wpf The TargetFramework version for the WPF tasks needs to be updated to net10.0. Here's the PR that did this last year: dotnet/wpf#8330

@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
f33b694 
…ld 20241213.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24613.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 10.0.0-alpha.1.24605.3 -> To Version 10.0.0-alpha.1.24612.1 (parent: Microsoft.WindowsDesktop.App.Ref
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
14a99db 
…ld 20241213.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24613.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
a63284c 
…ld 20241214.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24614.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
20610e3 
…ld 20241217.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24607.1 -> To Version 10.0.0-alpha.1.24617.1
@dkurepa dkurepa mentioned this pull request Dec 18, 2024
Open
@dsplaisted
Copy link
Member

@dotnet/wpf-developers @singhashish-wpf The TargetFramework version for the WPF tasks needs to be updated to net10.0. Here's the PR that did this last year: dotnet/wpf#8330

Ping @dotnet/wpf-developers @singhashish-wpf We need a small version update in the WinFX targets to support .NET 10.

@himgoyalmicro himgoyalmicro mentioned this pull request Dec 19, 2024
Merged
@himgoyalmicro
Copy link

Pushed the suggested change. Thanks @dsplaisted

@ViktorHofer
Copy link
Member

Something is still looking for the net9.0 version of the PresentationBuildTask:

C:\h\w\BEBE09FE\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\BEBE09FE\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net9.0\PresentationBuildTasks.dll. Could not load file or assembly 'C:\h\w\BEBE09FE\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net9.0\PresentationBuildTasks.dll'. The system cannot find the path specified. Confirm that the declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\BEBE09FE\t\dotnetSdkTests\cnb4hnr2.jgv\It_publishes_---F395A6ED\It_publishes_---

@ViktorHofer
Copy link
Member

Closing in favor of #45597

@ViktorHofer ViktorHofer deleted the darc-main-237be5fa-2f85-4426-83cf-fc67f44521f9 branch December 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @dsplaisted @himgoyalmicro @ViktorHofer