Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ProduceReferenceAssembly to true #12720

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Jul 30, 2020

Fixes #2521

@sfoslund sfoslund requested review from dsplaisted and wli3 July 30, 2020 19:46
@RussKie
Copy link
Member

RussKie commented Sep 22, 2020

It is extremely disappointing that such behavioural changes are not clearly communicated to all consumers. This change has led to a loss of productivity across multiple teams.

@wli3
Copy link

wli3 commented Sep 22, 2020

@RussKie what would be a better communication? We did not consider this as a breaking change due to it is "adding more". If we do, the breaking change list might be too busy. At the same time, from my understanding the root winforms's break is caused by another runtime bug.

@RussKie
Copy link
Member

RussKie commented Sep 22, 2020

what would be a better communication?

I suppose an email to first party consumers about a change, and discuss how it may affect them would be a good start. How is consumer expected to find our what needs fixing when they stare at random build failures?

We did not consider this as a breaking change due to it is "adding more".

"Adding more" can clearly be breaking, as in this case.

At the same time, from my understanding the root winforms's break is caused by another runtime bug.

There are multiple compound issues, this was one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default ProduceReferenceAssembly to true
4 participants