Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update dependencies from dotnet/msbuild #12730

Merged
merged 15 commits into from
Aug 3, 2020
Merged

[master] Update dependencies from dotnet/msbuild #12730

merged 15 commits into from
Aug 3, 2020

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 31, 2020 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 541ffb79-a58a-4b7b-321c-08d8080363b6
  • Build: 20200801.1
  • Date Produced: 8/1/2020 12:59 AM
  • Commit: 15307131458845313df37549b1e25c5076519809
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.Build.Localization: from 16.8.0-preview-20380-03 to 16.8.0-preview-20401-01
    • Microsoft.Build: from 16.8.0-preview-20380-03 to 16.8.0-preview-20401-01

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
a293dcb 
…0731.1

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20380-03 -> To Version 16.8.0-preview-20381-01
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 31, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot and others added 12 commits July 31, 2020 19:26
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
9a25d4e 
…0731.3

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20380-03 -> To Version 16.8.0-preview-20381-03
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
2b3e9ec 
…0731.2

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-03 -> To Version 16.8.0-preview-20381-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
616e35f 
…0731.4

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-02 -> To Version 16.8.0-preview-20381-04
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
0fa33a0 
…0731.5

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-04 -> To Version 16.8.0-preview-20381-05
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
59cb87b 
…0731.6

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-05 -> To Version 16.8.0-preview-20381-06
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
e13b36d 
…0731.7

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-06 -> To Version 16.8.0-preview-20381-07
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
8477dbe 
…0731.8

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-07 -> To Version 16.8.0-preview-20381-08
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
0e1cef6 
…0731.9

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-08 -> To Version 16.8.0-preview-20381-09
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
6cae8fc 
…0731.11

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-09 -> To Version 16.8.0-preview-20381-11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
258e22f 
…0731.10

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-11 -> To Version 16.8.0-preview-20381-10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
e803b9f 
…0731.12

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20381-10 -> To Version 16.8.0-preview-20381-12
@sfoslund
Merge remote-tracking branch 'upstream/master' into darc-master-59e77…
17878dc 
…80a-937b-43cf-b666-2192d39658ce
@sfoslund
Copy link
Member

It looks like #12422 and #12720 got checked in so close together that we didn't realize the analyzers change would effect the net5.0 test. I've updated that test attribute so it matches the rest in the analyzers PR (cc @jmarolf)

sfoslund
sfoslund suggested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to avoid automerge. @wli3 @dsplaisted could you please review?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 31, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ❌ Standard Merge Policies There are reviews that have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@sfoslund sfoslund force-pushed the darc-master-59e7780a-937b-43cf-b666-2192d39658ce branch from cd225d7 to f65150b Compare July 31, 2020 23:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2020…
d817d97 
…0801.1

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20380-03 -> To Version 16.8.0-preview-20401-01
@sfoslund sfoslund merged commit 1952cd8 into master Aug 3, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-59e7780a-937b-43cf-b666-2192d39658ce branch August 3, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoslund sfoslund sfoslund approved these changes

@wli3 wli3 wli3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfoslund @wli3