Force current runtime and arch for GenerateResources on Core msbuild #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Nov 1, 2016
dsplaisted
approved these changes
Nov 2, 2016
eerhardt
approved these changes
Nov 2, 2016
| <NoLogo>true</NoLogo> | ||
|
|
||
| <!-- Temp Hack: https://github.com/Microsoft/msbuild/issues/720 --> | ||
| <!-- Workaround: https://github.com/Microsoft/msbuild/issues/720 --> | ||
| <OverrideToolHost Condition=" '$(DotnetHostPath)' != '' and '$(OverrideToolHost)' == ''">$(DotnetHostPath)</OverrideToolHost> |
There was a problem hiding this comment.
I think this can be removed. It should no longer be needed/used.
(Obviously leaving it in now doesn't hurt anything. So maybe we should remove it after RC.)
ScenarioBuild a project with .resx file using dotnet CLI with different architecture than target. i.e. dotnet.exe is 32-bit and application being built is 64-bit. BugWorkaroundsSet the following in your project: <PropertyGroup>
<GenerateResourceMSBuildArchitecture>CurrentArchitecture</GenerateResourceMSBuildArchitecture>
<GenerateResourceMSBuildRuntime>CurrentRuntime</GenerateResourceMSBuildRuntime>
</PropertyGroup>RiskLow risk - we only change the property on Core MSBuild and it has no impact on VS builds Performance ImpactNone Regression AnalysisNot a regression, |
|
@MattGertz for approval |
|
Approved. |
sbomer
pushed a commit
to sbomer/sdk
that referenced
this pull request
Sep 19, 2017
Update the License
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Mar 20, 2023
Cancellation for `CreateNewImage` task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #346 with a workaround for dotnet/msbuild#1293
Also cleaning up the nearby usage 'hack' to just 'workaround' ;)
@srivatsn @rainersigwald @NTaylorMullen @dotnet/project-system