Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile OSName in source-build with repo usage #1639

Closed
dseefeld opened this issue Jul 2, 2020 · 1 comment
Closed

Reconcile OSName in source-build with repo usage #1639

dseefeld opened this issue Jul 2, 2020 · 1 comment
Assignees
Labels
area-infra Source-build infrastructure and reporting

Comments

@dseefeld
Copy link
Contributor

dseefeld commented Jul 2, 2020

An issue with 5.0 building on OSX turned out to be that we were setting OSName incorrectly in the installer build. I think the issue may exist in 3.1 as well. OSName is checked in some of the repos as "$(OSName)" == "osx" but we're setting it to something like osx.10.14 in this code:

<OverrideTargetRid>$(TargetRid)</OverrideTargetRid>
<OverrideTargetRid Condition="'$(TargetOS)' == 'OSX'">osx-x64</OverrideTargetRid>
<OSNameOverride>$(TargetRid.Substring(0, $(TargetRid.IndexOf("-"))))</OSNameOverride>
That same code was in installer.proj in 5.0 (copied over). This was causing the check to fail in the installer repo and it was setting CreateCrossgenSymbols to true here: https://github.com/dotnet/installer/blob/efcb9c319c41105e769afcafbd6c8860f7411f25/src/redist/targets/Crossgen.targets#L107-L109

The fix in 5.0 was to update this line:

<OSNameOverride>$(TargetRid.Substring(0, $(TargetRid.IndexOf("-"))))</OSNameOverride>
to the following:

<OSNameOverride>$(OverrideTargetRid.Substring(0, $(OverrideTargetRid.IndexOf("-"))))</OSNameOverride>

@dseefeld dseefeld added triaged area-infra Source-build infrastructure and reporting labels Jul 16, 2020
@dseefeld dseefeld self-assigned this Jul 16, 2020
@MichaelSimons
Copy link
Member

MichaelSimons commented Oct 20, 2022

[Triage] This code has been refactored some since it was originally opened. The OSX issue is N/A until #2909 is implemented in .NET 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
None yet
Development

No branches or pull requests

2 participants