You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a potential that the versions will diverge if one of the package names change, one of them is manually updated. And actually divergence can be intentional, for targeting packs:
Once they diverge, I think that the tooling will bring down two versions of the intermediate nupkg, which doesn't represent what source-build can actually do in a tarball.
Picking a single dependency node is how we decide what the coherent graph of repos should be.
I think the tooling should detect when a repo is set up this way, and fail pre-emptively.
For #2034, we'll probably need to restore multiple intermediate nupkgs from a single upstream, but all of them should come from a single dependency node.
The text was updated successfully, but these errors were encountered:
Triage: this is just a safeguard, but when this scenario happens down the road, we don't know how it will show up--if it's easy to diagnose a build break or if it will silently break the SDK. This seems like it won't be a problem in the initial work but it's worth tracking.
MichaelSimons
changed the title
ArPow: intermediate nupkg restore tooling should detect and fail if multiple <SourceBuild .../> elements exist for one upstream
[ArPow] intermediate nupkg restore tooling should detect and fail if multiple <SourceBuild .../> elements exist for one upstream
May 28, 2021
If we have dependencies defined like this:
There's a potential that the versions will diverge if one of the package names change, one of them is manually updated. And actually divergence can be intentional, for targeting packs:
Once they diverge, I think that the tooling will bring down two versions of the intermediate nupkg, which doesn't represent what source-build can actually do in a tarball.
Picking a single dependency node is how we decide what the coherent graph of repos should be.
I think the tooling should detect when a repo is set up this way, and fail pre-emptively.
For #2034, we'll probably need to restore multiple intermediate nupkgs from a single upstream, but all of them should come from a single dependency node.
The text was updated successfully, but these errors were encountered: