Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Data.SqlClient,4.8.2 to SBRP #2505

Closed
eerhardt opened this issue Oct 13, 2021 · 1 comment · Fixed by dotnet/source-build-reference-packages#266
Closed

Add System.Data.SqlClient,4.8.2 to SBRP #2505

eerhardt opened this issue Oct 13, 2021 · 1 comment · Fixed by dotnet/source-build-reference-packages#266
Assignees
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@eerhardt
Copy link
Member

eerhardt commented Oct 13, 2021

This package is referenced by dotnet/runtime -

https://github.com/dotnet/runtime/blob/5829730d1671cd96e9997292b5059b122c35c67d/src/libraries/shims/generated/Directory.Build.props#L25-L27

https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/shims/manual/System.Data.csproj#L6-L7

We have the 4.8.1 version in the "pre-arcade" branch of SBRP already:

https://github.com/dotnet/source-build-reference-packages/tree/pre-arcade/src/referencePackages/src/system.data.sqlclient

We should add the 4.8.2 version to the 6.0 SBRP to eliminate this pre-built in dotnet/runtime source-build in support of #2421.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-additional-repos Adding additional contributing repos untriaged labels Oct 13, 2021
@dseefeld dseefeld added area-prebuilts Reducing the number of prebuilt packages in the tarball and removed area-additional-repos Adding additional contributing repos labels Oct 13, 2021
@dseefeld
Copy link
Contributor

Additionally, we should add System.Data.SqlClient,4.8.3 in anticipation of this change coming up in runtime: dotnet/runtime#60345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants