Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBRP tooling to support text-only packages #2655

Closed
MichaelSimons opened this issue Dec 3, 2021 · 4 comments · Fixed by dotnet/source-build-reference-packages#427
Closed
Assignees
Labels
area-sbrp Source build reference packages

Comments

@MichaelSimons
Copy link
Member

Tooling should exist to automate the process for adding a text-only package to SBRP. User should be able to provide the package name and version with an optional feed. The tooling in dotnet/installers around text-only package generation may be a good reference for implementing this.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-infra Source-build infrastructure and reporting untriaged labels Dec 3, 2021
@MichaelSimons MichaelSimons added area-sbrp Source build reference packages and removed area-infra Source-build infrastructure and reporting labels Jul 12, 2022
@oleksandr-didyk
Copy link
Contributor

Additional information:

  • existing tooling in dotnet/installers can be found here
  • entry point for the resulting tooling should be the ./generate.sh in SB repo root (source)
  • usage of the prepared mechanism should be documented at least in the source build docs (available here)

@oleksandr-didyk
Copy link
Contributor

Update on progress -> started migrating MSBuild logic found in dotnet/installers to SBRP; in general, the idea behind the solution is to have an MSBuild project similar to that in dotnet/installers, with the small difference that the package name, version and optionally feed are provided as CL properties provided by the entrypoint script

@oleksandr-didyk
Copy link
Contributor

Update on progress -> during PR review it was decided to extend the current task goal with merging the existing reference package generation tooling and the proposed text-only one for better maintenance / re-usability; currently working on adding that to the opened PR

@oleksandr-didyk
Copy link
Contributor

Update on progress -> PR feedback incorporated into the branch, waiting for re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sbrp Source build reference packages
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants