Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for buildabilty between SDK and previously-source-built #3157

Open
crummel opened this issue Dec 6, 2022 · 2 comments
Open

Add check for buildabilty between SDK and previously-source-built #3157

crummel opened this issue Dec 6, 2022 · 2 comments
Labels
area-product-experience Improvements in the end-user's product experience up-for-grabs

Comments

@crummel
Copy link
Contributor

crummel commented Dec 6, 2022

After finding the issue with #3156, we determined that building with a previously-source-built-artifacts and SDK that don't match is a broader problem that can show up in multiple ways. If we implement something like #2758 to make previously-source-built archives include the RID in their name, we would easily be able to check for this condition in build.sh before the build starts and give the user a clear error immediately instead of waiting until the user gets to runtime/ASP.NET/installer to fail with a confusing error.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-additional-repos Adding additional contributing repos untriaged labels Dec 6, 2022
@MichaelSimons MichaelSimons added area-testing Improvements in CI and testing area-product-experience Improvements in the end-user's product experience and removed area-additional-repos Adding additional contributing repos untriaged area-testing Improvements in CI and testing labels Dec 8, 2022
@MichaelSimons MichaelSimons moved this to 8.0 On Deck in .NET Source Build Dec 8, 2022
@MichaelSimons MichaelSimons moved this from 8.0 On Deck to 8.0 Backlog in .NET Source Build Dec 8, 2022
@MichaelSimons
Copy link
Member

[Triage] This requires being able to detect which rid previously source-built artifacts are for.

@mthalman
Copy link
Member

Dependent on #2928

@MichaelSimons MichaelSimons moved this from Needs Review to Backlog in .NET Source Build Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-product-experience Improvements in the end-user's product experience up-for-grabs
Projects
Status: Backlog
Development

No branches or pull requests

3 participants