Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old version of Microsoft.Private.Intellisense in source-build-reference-packages #3611

Closed
carlossanlop opened this issue Sep 1, 2023 · 5 comments
Assignees
Labels
area-infra Source-build infrastructure and reporting untriaged

Comments

@carlossanlop
Copy link
Member

Can't open issues in dotnet/source-build-reference-packages, so I'm opening it here and assigning it to myself.

I have this PR that manually adds the latest Microsoft.Private.Intellisense version as text to that repo: dotnet/source-build-reference-packages#774

In the comments I was given the suggestion to delete the older version of the package. I can't do it in the same PR because there are other repos that have not updated to the latest package version. I first need to ensure no one is consuming it and then I can safely delete the old version files.

Since this work should be done before we ship .NET 8, I am using that milestone.

cc @ViktorHofer @mthalman @MichaelSimons

@carlossanlop carlossanlop self-assigned this Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Can't open issues in dotnet/source-build-reference-packages, so I'm opening it here and assigning it to myself.

I have this PR that manually adds the latest Microsoft.Private.Intellisense version as text to that repo: dotnet/source-build-reference-packages#774

In the comments I was given the suggestion to delete the older version of the package. I can't do it in the same PR because there are other repos that have not updated to the latest package version. I first need to ensure no one is consuming it and then I can safely delete the old version files.

Since this work should be done before we ship .NET 8, I am using that milestone.

cc @ViktorHofer @mthalman @MichaelSimons

Author: carlossanlop
Assignees: carlossanlop
Labels:

documentation, area-Infrastructure-libraries

Milestone: 8.0.0

@mthalman
Copy link
Member

mthalman commented Sep 1, 2023

SBRP issues can be logged at https://github.com/dotnet/source-build. I'll move this issue there.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infra Source-build infrastructure and reporting label Sep 1, 2023
@mthalman mthalman transferred this issue from dotnet/runtime Sep 1, 2023
@mthalman
Copy link
Member

mthalman commented Sep 1, 2023

I can't do it in the same PR because there are other repos that have not updated to the latest package version.

What other repos? The only ones I see are winforms and wpf, neither of which participate in source-build since it's Linux-only. Since they don't participate in source-build, they don't consume the SBRP package.

@carlossanlop
Copy link
Member Author

What other repos? The only ones I see are winforms and wpf

Yes, those repos. OK, so runtime is the only one with the problem. I'll delete the old code then.

@MichaelSimons
Copy link
Member

It appears this was addressed with dotnet/source-build-reference-packages#774. Is there any reason to keep this issue open?

@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting untriaged
Projects
Archived in project
Development

No branches or pull requests

3 participants