Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase clarity in test case skipping #3615

Closed
ellahathaway opened this issue Sep 7, 2023 · 1 comment · Fixed by dotnet/installer#19290
Closed

Increase clarity in test case skipping #3615

ellahathaway opened this issue Sep 7, 2023 · 1 comment · Fixed by dotnet/installer#19290

Comments

@ellahathaway
Copy link
Member

In the Microsoft.DotNet.SourceBuild.SmokeTests.SdkContentTests, we include both Config.MsftSdkTarballPath and Config.SdkTarballPath as variables to check for skipping the test. That is, if either of these variables is null or contains whitespace, the test will be skipped. This approach lacks transparency from a user experience perspective, as it doesn't clearly indicate which variable triggered the test to skip.

A more user-friendly solution would involve introducing a variable such as "IncludeSdkContentTests" that determines whether or not to skip the test, and subsequently asserting that neither Config.MsftSdkTarballPath nor Config.SdkTarballPath is null or contains whitespace. By adopting this approach, we empower users to discern which specific variable caused the test to be omitted.

@ellahathaway
Copy link
Member Author

ellahathaway commented Apr 5, 2024

This will be closed with the changes from dotnet/installer#19290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant