You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Microsoft.DotNet.SourceBuild.SmokeTests.SdkContentTests, we include both Config.MsftSdkTarballPath and Config.SdkTarballPath as variables to check for skipping the test. That is, if either of these variables is null or contains whitespace, the test will be skipped. This approach lacks transparency from a user experience perspective, as it doesn't clearly indicate which variable triggered the test to skip.
A more user-friendly solution would involve introducing a variable such as "IncludeSdkContentTests" that determines whether or not to skip the test, and subsequently asserting that neither Config.MsftSdkTarballPath nor Config.SdkTarballPath is null or contains whitespace. By adopting this approach, we empower users to discern which specific variable caused the test to be omitted.
The text was updated successfully, but these errors were encountered:
In the Microsoft.DotNet.SourceBuild.SmokeTests.SdkContentTests, we include both Config.MsftSdkTarballPath and Config.SdkTarballPath as variables to check for skipping the test. That is, if either of these variables is null or contains whitespace, the test will be skipped. This approach lacks transparency from a user experience perspective, as it doesn't clearly indicate which variable triggered the test to skip.
A more user-friendly solution would involve introducing a variable such as "IncludeSdkContentTests" that determines whether or not to skip the test, and subsequently asserting that neither Config.MsftSdkTarballPath nor Config.SdkTarballPath is null or contains whitespace. By adopting this approach, we empower users to discern which specific variable caused the test to be omitted.
The text was updated successfully, but these errors were encountered: