Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateSdkSymbolsLayout task should fail if there are missing PDBs #3686

Closed
NikolaMilosavljevic opened this issue Oct 24, 2023 · 1 comment
Closed

CreateSdkSymbolsLayout task should fail if there are missing PDBs #3686

NikolaMilosavljevic opened this issue Oct 24, 2023 · 1 comment
Assignees
@NikolaMilosavljevic
Labels
area-build Improvements in source-build's own build process

Comments

@NikolaMilosavljevic
Copy link
Member

The task was set to ignore failures with dotnet/installer@9229a84

This was required due to missing PDBs, likely related to prebuilts, see dotnet/installer#17482 (comment)

We should re-enable failure for this task, and likely take any prebuilts into account, when doing verification.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Oct 24, 2023
@NikolaMilosavljevic NikolaMilosavljevic changed the title CreatSdkSymbolsLayout task should fail if there are missing PDBs CreateSdkSymbolsLayout task should fail if there are missing PDBs Oct 24, 2023
@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Oct 26, 2023
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Apr 15, 2024
Closed
@NikolaMilosavljevic
Copy link
Member Author

Closing in favor of #4330

@github-project-automation github-project-automation bot moved this from 9.0 to Done in .NET Source Build Apr 18, 2024
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-build Improvements in source-build's own build process
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @NikolaMilosavljevic