Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBRPs are present in multiple locations during source-build #4229

Closed
NikolaMilosavljevic opened this issue Mar 13, 2024 · 1 comment
Closed

SBRPs are present in multiple locations during source-build #4229

NikolaMilosavljevic opened this issue Mar 13, 2024 · 1 comment
Assignees
@NikolaMilosavljevic
Labels
area-infra Source-build infrastructure and reporting

Comments

@NikolaMilosavljevic
Copy link
Member

We have SBRPs in two locations during build:

  • prereqs/packages/previously-source-built/SourceBuildReferencePackages - extracted from PSB archive
  • prereqs/packages/reference - copied from location above, in init-build.proj. This location is also updated with newly built SBRPs, after deleting all existing content.

We shouldn't have SBRPs in prereqs/packages/previously-source-built/SourceBuildReferencePackages during build. The only scenario where packages from this location would be used is if we stopped building an SBRP package. An old package would be used and introduce a poison.

It's better to get a build failure, than to discover the issue while running tests in a poisoned build.
@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Mar 14, 2024
@MichaelSimons MichaelSimons added area-infra Source-build infrastructure and reporting and removed untriaged area-prebuilt-reduction labels Mar 14, 2024
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Mar 20, 2024
Merged
@MichaelSimons MichaelSimons moved this from 9.0 to In Progress in .NET Source Build Mar 21, 2024
@NikolaMilosavljevic
Copy link
Member Author

Fixed with dotnet/installer#19114

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-infra Source-build infrastructure and reporting
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @NikolaMilosavljevic