Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet feed non-determinism should be accounted for in Arcade source build #4311

Open
mthalman opened this issue Apr 9, 2024 · 2 comments
Open
Labels
area-arcade Common Arcade source-build infra

Comments

@mthalman
Copy link
Member

mthalman commented Apr 9, 2024

The changes in dotnet/installer#19114 addressed NuGet's package restore non-determinism as described in #4206 via the use of package source mappings. That same approach is also needed for Arcade source build (aka ArPow) because the source build leg of product repos can also have multiple feeds listed in their NuGet.config files. With this non-determinism, it is possible that a package could be retrieved from an online feed rather than the source built cache feed. That would lead to prebuilts.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-infra Source-build infrastructure and reporting untriaged labels Apr 9, 2024
@MichaelSimons MichaelSimons added area-arcade Common Arcade source-build infra and removed area-infra Source-build infrastructure and reporting untriaged labels Apr 18, 2024
@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Apr 18, 2024
@MichaelSimons
Copy link
Member

[Triage] This will likely be a problem once arcade updates the SDK to a newer version with the NuGet change.

@MichaelSimons
Copy link
Member

[Triage] The speculation is that this might not break at the repo level because there is only one local package feed whereas in the product source build there were multiples.

@NikolaMilosavljevic - this is an issue we feel would be good to proactively address before it becomes a blocking issue.

@MichaelSimons MichaelSimons moved this from 9.0 to 9.0 Preview 4 in .NET Source Build Apr 18, 2024
@MichaelSimons MichaelSimons moved this from 9.0 Preview 4 to 9.0 in .NET Source Build May 8, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 1, 2024
@MichaelSimons MichaelSimons moved this from 10.0 to 9.0 in .NET Source Build Jul 2, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-arcade Common Arcade source-build infra
Projects
Status: 10.0
Development

No branches or pull requests

3 participants