Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Show Scala version in microsoft-spark*.jar filename #293

Closed
imback82 opened this issue Oct 13, 2019 · 7 comments · Fixed by #728
Closed

[FEATURE REQUEST]: Show Scala version in microsoft-spark*.jar filename #293

imback82 opened this issue Oct 13, 2019 · 7 comments · Fixed by #728
Labels
enhancement New feature or request
Milestone

Comments

@imback82
Copy link
Contributor

Currently, scala version is not embedded in the microsoft-spark JAR name. This will be useful for the user when Spark 3.0 is released which uses 2.12 scala by default.

@imback82 imback82 added the enhancement New feature or request label Oct 13, 2019
@imback82
Copy link
Contributor Author

One suggestion is:
current: microsoft-spark-2.4.x-0.6.0.jar
new: microsoft-spark-2.4.x_2.11-0.6.0.jar

Any other ideas? @suhsteve @rapoth @Niharikadutta @elvaliuliuliu @AFFogarty

@elvaliuliuliu
Copy link
Collaborator

@imback82 May I ask why we need to add scala version in our jar filename? It seems like Spark 3.0 and most Spark 2.4.x uses 2.12.x scala (except Spark 2.4.0 uses 2.11.x scala), and Spark 2.3.x uses 2.11.x scala.

@imback82
Copy link
Contributor Author

we want to have the consistent versioning with other scala packages in Maven (we plan to put these jars in Maven for livy integration).

@elvaliuliuliu
Copy link
Collaborator

Cool, I think microsoft-spark-2.4.x_2.11-0.6.0.jar is clear for me. Thanks.

@suhsteve
Copy link
Member

I think we should put the scala version in front. I currently see jars in HDInsight named this way.

proposed format: microsoft-spark_<scala version>-<spark version>-<dotnet version>.jar
example: microsoft-spark_2.11-2.4.x-0.6.0.jar

Should we keep the .x ?

@imback82 imback82 added this to the 1.0.0 milestone Oct 2, 2020
@imback82
Copy link
Contributor Author

imback82 commented Oct 2, 2020

microsoft-spark-3.0_2.12-1.0.0.jar
microsoft-spark-2.4_2.11-1.0.0.jar

@imback82
Copy link
Contributor Author

imback82 commented Oct 9, 2020

We will go with:

microsoft-spark-3-0_2.12-1.0.0.jar
microsoft-spark-2-4_2.11-1.0.0.jar

, simliar to https://github.com/apache/spark/blob/master/external/kafka-0-10/pom.xml

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants