XML comment crefs unusable with shared/duplicate CsWin32 #10524
Labels
tracking-external-issue
An issue is caused by an external system and won't be fixed in this repo
Milestone
Comments
JeremyKuhne
added
the
tracking-external-issue
JeremyKuhne
added a commit
to JeremyKuhne/winforms
that referenced
this issue
Dec 22, 2023
This is a rough prototype of a shared interop with System.Drawing.Common. It introduces a new base assembly for shared CsWin32 and other low-level support code. Converted HGLOBAL, DEVMODE and related stuff to the new shared pattern. Also used the CsWin32 generated GdiplusStartup. I have almost no idea if packaging is correct here. Assuming it isn't. `crefs` don't work right when there is overlap in internals. dotnet#10524 tracks this, and this change disables the relevant warnings. I've only smoke tested this with the WinFormsControlsTest.
|
Tracking the issue here dotnet/roslyn#71442 |
JeremyKuhne
added a commit
that referenced
this issue
Jan 4, 2024
This change adds a shared interop assembly with `System.Drawing.Common`. It introduces a new base assembly for shared CsWin32 and other low-level support code called `System.Private.Windows.Core`. This assembly is part of the `System.Drawing.Common` package. Converted `HGLOBAL`, `DEVMODE` and related stuff to the new shared pattern. Also used the CsWin32 generated `GdiplusStartup`. `crefs` don't work right when there is overlap in internals. #10524 tracks this, and this change disables the relevant warnings. Smoke tested this with the WinFormsControlsTest.
KlausLoeffelmann
pushed a commit
to KlausLoeffelmann/winforms
that referenced
this issue
Mar 5, 2024
This change adds a shared interop assembly with `System.Drawing.Common`. It introduces a new base assembly for shared CsWin32 and other low-level support code called `System.Private.Windows.Core`. This assembly is part of the `System.Drawing.Common` package. Converted `HGLOBAL`, `DEVMODE` and related stuff to the new shared pattern. Also used the CsWin32 generated `GdiplusStartup`. `crefs` don't work right when there is overlap in internals. dotnet#10524 tracks this, and this change disables the relevant warnings. Smoke tested this with the WinFormsControlsTest.
|
@JeremyKuhne was this resolved by using a common base library? |
|
This issue is just a tracking issue for the linked C# feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
XML comment
crefs don't resolve the same way code does. They have visibility to everything, which prevents us from using them when we have duplicate type names in dependent assemblies or types that cross assemblies. We either have to turn off CS1574 and CS1580, or remove lots of existingcrefs.#10320 (comment)
The text was updated successfully, but these errors were encountered: