Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewButtonColumn #12814

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jan 20, 2025

related #10453

Proposed changes

Add unit tests for DataGridViewButtonColumn.cs to test its methods & properties

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 98.31933% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.23617%. Comparing base (3b8e1a6) to head (22faac6).
Report is 29 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12814         +/-   ##
===================================================
+ Coverage   76.18925%   76.23617%   +0.04692%     
===================================================
  Files           3195        3200          +5     
  Lines         640404      640608        +204     
  Branches       47239       47231          -8     
===================================================
+ Hits          487919      488375        +456     
+ Misses        148947      148708        -239     
+ Partials        3538        3525         -13     
Flag Coverage Δ
Debug 76.23617% <98.31933%> (+0.04692%) ⬆️
integration 18.16513% <ø> (+0.01210%) ⬆️
production 50.19315% <ø> (+0.06819%) ⬆️
test 97.04167% <98.31933%> (+0.01773%) ⬆️
unit 47.59381% <ø> (+0.04040%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 21, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM

@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 22, 2025
@Zheng-Li01 Zheng-Li01 removed their assignment Jan 22, 2025
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jan 22, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit c3a752b into dotnet:main Jan 22, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 22, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jan 22, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_DataGridViewButtonColumn branch January 23, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants