-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage for DataGridViewButtonColumn #12814
Add code coverage for DataGridViewButtonColumn #12814
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12814 +/- ##
===================================================
+ Coverage 76.18925% 76.23617% +0.04692%
===================================================
Files 3195 3200 +5
Lines 640404 640608 +204
Branches 47239 47231 -8
===================================================
+ Hits 487919 488375 +456
+ Misses 148947 148708 -239
+ Partials 3538 3525 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewButtonColumnTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than small comments, LGTM
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewButtonColumnTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewButtonColumnTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewButtonColumnTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewButtonColumnTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
related #10453
Proposed changes
Add unit tests for DataGridViewButtonColumn.cs to test its methods & properties
Microsoft Reviewers: Open in CodeFlow