Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More OLE related refactoring #12840

Merged
merged 3 commits into from
Jan 25, 2025
Merged

More OLE related refactoring #12840

merged 3 commits into from
Jan 25, 2025

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Jan 25, 2025

This makes a number of changes to continue the move of OLE code to Core.

  • Move clipboard related switch to Core
  • Move CsWin32 definitions to Core
  • Rename older PInvokeCore files
  • Unnest a few more classes
  • Move FeatureSwitchDefinition to FeatureSwitches
  • Move JsonData to Core
  • Move TypeExtensions to Core

Note that setting typeof() to a static actually results in lower perf. typeof() gets replaced with a pointer by the JIT.

Microsoft Reviewers: Open in CodeFlow

This makes a number of changes to continue the move of OLE code to Core.

- Move clipboard related switch to Core
- Move CsWin32 definitions to Core
- Rename older PInvokeCore files
- Unnest a few more classes
- Move FeatureSwitchDefinition to FeatureSwitches
- Move JsonData to Core
- Move TypeExtensions to Core

Note that setting `typeof()` to a static actually results in lower perf. `typeof()` gets replaced with a pointer by the JIT.
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 86.70520% with 69 lines in your changes missing coverage. Please review.

Project coverage is 76.13281%. Comparing base (cc8aabe) to head (32dbffb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12840         +/-   ##
===================================================
- Coverage   76.13720%   76.13281%   -0.00440%     
===================================================
  Files           3240        3242          +2     
  Lines         642343      642363         +20     
  Branches       47270       47271          +1     
===================================================
- Hits          489062      489049         -13     
- Misses        149741      149772         +31     
- Partials        3540        3542          +2     
Flag Coverage Δ
Debug 76.13281% <86.70520%> (-0.00440%) ⬇️
integration 18.10386% <20.65217%> (-0.00546%) ⬇️
production 50.07514% <87.17391%> (-0.00684%) ⬇️
test 96.97742% <83.05085%> (-0.00033%) ⬇️
unit 47.51071% <85.43478%> (+0.01861%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JeremyKuhne JeremyKuhne merged commit 620b123 into dotnet:main Jan 25, 2025
8 checks passed
@JeremyKuhne JeremyKuhne deleted the factorclip5 branch January 25, 2025 05:43
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants