PropertyGrid: objects not expandable

[RussKie]

• Have you experienced this same bug with .NET Framework?: No

Problem description:

The property grid does not allow to expand complex objects if those aren't at the top level of object hierarchy.

Actual behavior:

Expected behavior:

Object at all levels are expandable.

Minimal repro:

Run WinFormsControlsClassicTests and WinformsControlsTest side-by-side, click [Collection Editors] button and compare the property grids.

[zsd4yr]

@DustinCampbell, @AdamYoblick and I feel like you mentioned something here -- do you have any thoughts?

[weltkante]

ComponentConverter should be the one responsible for expanding in the property grid (it overrides GetProperties, same as ExpandableObjectConverter does). It is linked on Desktop Framework via a TypeConverterAttribute attribute on the IComponent interface, but I think its missing in corefx even though the documentation says it should still be there.

[DustinCampbell]

@DustinCampbell, @AdamYoblick and I feel like you mentioned something here -- do you have any thoughts?

This is about the .NET Core property grid and not the framework version, which gets used in VS. So, I don't really have anything to add.

[RussKie]

Thank you @hughbe 🚀

[danmoseley]

reopening since apparently this is desired for 3.0 GA which means it would need a port PR.

cc @safern.

[danmoseley]

(if not, please re-close )

[zsd4yr]

@danmosemsft will someone cherry pick the change in corefx master into the 3.0 GA branch or should @hughbe make that PR?

@hughbe please make a PR in CoreFX with this change targeting their 3.0 GA branch

[danmoseley]

@RussKie perhaps this can be closed - maybe after our code flows and you've validated ?

[RussKie]

@danmosemsft this looks like fixed in 5.0 but 3.1 is still broken. Is there anything we can do to get it fixed in 3.1 as well?

• 3.1 Preview1
  

• 5.0
  

[weltkante]

Seems to work for me in 3.0 GA, can't test 3.1 right now

example

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();

        PropertyGrid pg;
        Controls.Add(pg = new PropertyGrid() { Dock = DockStyle.Fill });
        pg.SelectedObject = new Dummy();
    }

}

public class Dummy
{
    public ListView MyListView { get; } = new ListView();
}

[safern]

@RussKie the fix seems to be in the 3.1 branch... have you guys consumed the latest Microsoft.NETCore.App from 3.1? Would you mind checking what version you tested agains?

Here's the source code for 3.1: https://github.com/dotnet/corefx/blob/release/3.1/src/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs#L139

[RussKie]

Thank you for the confirmation.
I have created brand new apps targeting 3.0 and 3.1 outside the repo, and in both cases it worked.