Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding additional TypeConverter metadata to Resx #8297

Open
Tracked by #6267
JeremyKuhne opened this issue Nov 29, 2022 · 3 comments
Open
Tracked by #6267

Investigate adding additional TypeConverter metadata to Resx #8297

JeremyKuhne opened this issue Nov 29, 2022 · 3 comments
Assignees
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization area-VSDesigner Windows Forms out-of-proc designer related issues
Milestone

Comments

@JeremyKuhne
Copy link
Member

Resx uses TypeConverters when available to convert data to/from string and byte[]. The specific type converter used isn't recorded, it's only the active one for typeof(T) that is considered. For unwrapping it would be good to know the specific type converter used and attempt to use the exact one if possible and give diagnostic information of some sort.

In order for this sort of change to have meaning, all copies of the Resx code need to be considered (MSBuild has their own, for example.)

cc @GrabYourPitchforks

@JeremyKuhne JeremyKuhne added this to the .NET 8.0 milestone Nov 29, 2022
@JeremyKuhne JeremyKuhne added the area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization label May 1, 2023
@JeremyKuhne
Copy link
Member Author

This is related to the BinaryFormatter in that if we maintained the converter information, we might be able to temporarily substitute in a converter that isn't applied via a hard coded attribute for a given type.

@JeremyKuhne JeremyKuhne modified the milestones: .NET 8.0, .NET 9.0 Aug 16, 2023
@JeremyKuhne JeremyKuhne added the area-VSDesigner Windows Forms out-of-proc designer related issues label Jul 24, 2024
@JeremyKuhne JeremyKuhne modified the milestones: .NET 9.0, .NET 10.0 Jul 24, 2024
@JeremyKuhne
Copy link
Member Author

@Shyam-Gupta this is the feature you're working on.

@AraHaan
Copy link
Member

AraHaan commented Sep 7, 2024

I feel like the designer should be updated to use alternatives as well so when people set localizable to true, they would not need to remake their resx files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization area-VSDesigner Windows Forms out-of-proc designer related issues
Projects
None yet
Development

No branches or pull requests

3 participants