Exception on keyboard layout switch with InvariantGlobalization

[OwnageIsMagic]

.NET version

Microsoft.WindowsDesktop.App 7.0.5

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

Unhandled exception. System.Globalization.CultureNotFoundException: Only the invariant culture is supported in globalization-invariant mode. See https://aka.ms/GlobalizationInvariantMode for more information. (Parameter 'culture')
1049 (0x0419) is an invalid culture identifier.
   at System.Globalization.CultureData.GetCultureData(Int32 culture, Boolean bUseUserOverride)
   at System.Globalization.CultureInfo..ctor(Int32 culture, Boolean useUserOverride)
   at System.Windows.Forms.InputLanguage.get_Culture()
   at System.Windows.Forms.InputLanguageChangedEventArgs..ctor(InputLanguage inputLanguage, Byte charSet)
   at System.Windows.Forms.InputLanguage.CreateInputLanguageChangedEventArgs(Message m)
   at System.Windows.Forms.Control.WmInputLangChange(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ListView.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, WM msg, IntPtr wparam, IntPtr lparam)

Steps to reproduce

[elachlan]

@Olina-Zhang is there enough information for your team to go off of here for repro?

[OwnageIsMagic]

@elachlan here is repro

dotnet new winforms -o winformsInvariantRepro && cd winformsInvariantRepro
dotnet build /p:InvariantGlobalization=true && dotnet run --no-build
# change input language

confirmed for Microsoft.WindowsDesktop.App 8.0.0-preview.3.23178.1

[Olina-Zhang]

@OwnageIsMagic verified .Net 7.0 and 8.0 using above CLI, no exception, did you use some winforms controls?

[OwnageIsMagic]

@Olina-Zhang add additional input language to Windows here ms-settings:regionlanguage (Add a keyboard)
press Shift + Alt or Shift + Ctrl or Win + Space while Form1 is focused.

[OwnageIsMagic]

@elachlan problem is obvious from stacktrace provided
Control.WmInputLangChange(ref Message m) creates InputLanguageChangedEventArgs

winforms/src/System.Windows.Forms/src/System/Windows/Forms/InputLanguageChangedEventArgs.cs

Lines 35 to 38 in 761aebd

	public InputLanguageChangedEventArgs(InputLanguage inputLanguage, byte charSet)
	{
	InputLanguage = inputLanguage.OrThrowIfNull();
	Culture = inputLanguage.Culture;

calls InputLanguage.Culture which passing LCID to CultureInfo .ctor

winforms/src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs

Line 30 in 761aebd

public CultureInfo Culture => new CultureInfo(PARAM.LOWORD(_handle));

that ends up here
https://github.com/dotnet/runtime/blob/73cb995cff35b053d5b0d3daf319ac33769657d0/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs#L860-L872

[elachlan]

@DJm00n is your PR touching this stuff?

[DJm00n]

@elachlan no, it shouldn’t. It seems related to this breaking change. I can include a fix into my PR and return InvariantCulture from InputLanguage.Culture in globalization-invariant mode.

[OwnageIsMagic]

@elachlan the line is mostly the same since 2018
https://github.com/dotnet/winforms/blame/a7ca739d35a6369a10d50fb3d7e39c2aeb9dd620/src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs#L43
The problem is that InvariantGlobalization need special handling: with it enabled there is only 1 predefined CultureInfo instance (CultureInfo.Invariant)
possible workaround is to guard InputLanguage.Culture with check for InvariantGlobalization.

[OwnageIsMagic]

dotnet/runtime#81429

[OwnageIsMagic]

There is potential workaround using PredefinedCulturesOnly https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#predefined-cultures , but it only checked for from string ctor
see
https://github.com/dotnet/runtime/blob/182591af3ea67a09bca7e0516b950dafce71d5a6/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs#L860-L872
and
https://github.com/dotnet/runtime/blob/182591af3ea67a09bca7e0516b950dafce71d5a6/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs#L670-L682

[elachlan]

@OwnageIsMagic thanks for the explaination.

@DJm00n if your code is touching that area, then it might be a good idea to fix it whilst you are working on it.

[elachlan]

@OwnageIsMagic thanks! Yeah I am just a community member. Feel free to link the opened issue here.

[OwnageIsMagic]

@elachlan @DJm00n This issue can now be worked around by setting <PredefinedCulturesOnly>false</PredefinedCulturesOnly>.
On WinForms side we can lazy init this property, since we store InputLanguage from which this property value comes.
It's not used internally.
https://source.dot.net/#System.Windows.Forms/System/Windows/Forms/InputLanguageChangedEventArgs.cs,5bdc3016f89c5e99,references

[merriemcgaw]

@OwnageIsMagic and @elachlan you guys did all the work for us 😸 . Thanks a ton!