You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This hook only works if the formatter on the logrus logger outputs JSON. This requirement isn't detailed anywhere, or if it is it needs to be more obvious. I had to read the code to notice it attempts to unmarshal the entry string as JSON. The result was null data fields in sumo.
If everyone is agreeable I'll open a PR with 2 changes:
Update the sample in the README to show the setting of the formatter to logrus.JSONFormatter
Following how logrus does it, have the err from json.Unmarshal printed to stderr.
The text was updated successfully, but these errors were encountered:
This hook only works if the formatter on the logrus logger outputs JSON. This requirement isn't detailed anywhere, or if it is it needs to be more obvious. I had to read the code to notice it attempts to unmarshal the entry string as JSON. The result was null data fields in sumo.
If everyone is agreeable I'll open a PR with 2 changes:
logrus.JSONFormatter
json.Unmarshal
printed to stderr.The text was updated successfully, but these errors were encountered: