[typegoose] default assembler for creation is unusable #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onichandame
added a commit
to onichandame/nest-demo
that referenced
this pull request
Jun 17, 2021
onichandame
changed the title
doug-martin
pushed a commit
that referenced
this pull request
Jul 26, 2021
doug-martin
pushed a commit
that referenced
this pull request
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When trying the basic functionalities with typegoose, every GraphQL call to createOne/createMany fails with the error:
Id cannot be specified when updating or creating.Debug
The first place I found was this line, where the error is thrown.
Then I found that the error-throwing function was called with argument
{ id: undefined }. This weird object comes from here.Hence I believe that the default behaviour is broken somehow.
Solution
There are 2 places where it can be fixed(see the 2 links above). As one of them is related to an external dependency
class-transformer, it is easier to fix it from the other side.