Checked the length of key for checker framework

[ek08]

Checked the length of key IN JSONObject for Checker Framework

[stleary]

What problem does this code solve?
JavaCheck fails due to not being able to detect that zero-length keys are disallowed. I don't think there is any change to functionality.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED - after resolution of comments.

Starting 3-day comment window.

[johnjaylward]

I don't see what this change is adding to the code. The key can not be 0 length at that spot. Also, I would argue that the logic chosen for the check is wrong.

I'd argue it should look like this if you feel the check needs to be added

if (key.length() == 0 || Character.isLowerCase(key.charAt(0))) {
    return null;
}

[johnjaylward]

Check is not valid

[ek08]

I don't see what this change is adding to the code. The key can not be 0 length at that spot. Also, I would argue that the logic chosen for the check is wrong.

I'd argue it should look like this if you feel the check needs to be added

if (key.length() == 0 || Character.isLowerCase(key.charAt(0))) {
    return null;
}

Thanks for the correction. I agree with you that the length of key cannot be 0 length at that spot. So the logic of the check should be changed to

if (key.length() == 0 || Character.isLowerCase(key.charAt(0)))

[stleary]

Approval restored.