-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some TADs are offset/don't align visually #13
Comments
Hi @Naveen-Ahuja, thanks for reporting. This may happen due to data sparsity. I suggest two solutions:
If you would like to make a more thorough test, here is our code checking the effect of various combinations of parameters. As said,
|
@Naveen-Ahuja, can you make a minimal reproducible example? You can share data subset privately. Your results do look confusing, we never encountered them and I would dig deeper. |
Hi @mdozmorov, Thanks for the code. Would you please explain the parameter "normalization"? From what I understand, this parameter is for matrix generation, not for spectralTAD? |
This code is inspirational, shouldn't be used verbatim. Yes, "normalization" refers to our data preprocessing, it is not related to SpectralTAD. Most important are qual_filter = TRUE; z_clust = TRUE; max_tad_size <- 2000000; window_size <- max_tad_size / resolution; gap_threshold <- 0.8 |
@mdozmorov sorry for the delay, I had to get permission to share the data. Where can I privately share with you my hic matrix? |
Hi,
Spectral works really well but in some regions the TADs are offset or don't align well with what one would expect when visually inspecting them (see attached image). I wanted to know if you have any advice on fixing this or any particular parameter I should play with to fix this.
Here is how I called the TADs:
for (chr in chromosomes) {
out_path <- paste0("ctrl_p14_", chr, ".bedpe")
ctrl_p14<- strawr::straw("NONE", "/Users", chr, chr, "BP", 50000)
ctrl_p14_tad = SpectralTAD(ctrl_p14, chr = chr, resolution = 50000, levels = 3, qual_filter = FALSE, z_clust = FALSE, out_format= "juicebox", out_path=out_path)
}
Thank you
The text was updated successfully, but these errors were encountered: