Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics for ios is missing stacktrace #118

Closed
kirilmicev opened this issue Aug 23, 2019 · 8 comments
Closed

Crashlytics for ios is missing stacktrace #118

kirilmicev opened this issue Aug 23, 2019 · 8 comments
Assignees
Labels
Can't repro Unable to reproduce the issue as described ios relates to iOS platform runtime issue An issue related to app runtime

Comments

@kirilmicev
Copy link

In FirebasePlugin.m file when generating userInfo with stack trace you are using entry[@"source"] but it doesn't have value and nothing is sent to crashlytics.

I experimented and if you are using something like this will get a full stack trace

[entry[@"functionName"] stringByAppendingFormat:@" %@ %@", entry[@"fileName"], entry[@"lineNumber"]];

@dpa99c
Copy link
Owner

dpa99c commented Sep 3, 2019

@sagrawal31 Any ideas on this?
I believe this code was brought across from your fork in e2e32fe to resolve #57

@dpa99c dpa99c added ios relates to iOS platform runtime issue An issue related to app runtime labels Sep 3, 2019
@sagrawal31
Copy link
Collaborator

Yes, @dpa99c I copied from our fork and it should work. I'll cross-check it by EOD.

@dpa99c
Copy link
Owner

dpa99c commented Sep 3, 2019

Thanks, much appreciated 👍

@dpa99c
Copy link
Owner

dpa99c commented Sep 9, 2019

@sagrawal31 could you take a look at this when you get a moment?

@sagrawal31
Copy link
Collaborator

Yes @dpa99c I didn't get time last week. I'll debug this by tomorrow.

@sagrawal31
Copy link
Collaborator

Sorry, this is past a month 😄. But I did try this and seems it's working for me.

@dpa99c
Copy link
Owner

dpa99c commented Oct 24, 2019

I can confirm the current implementation works correctly after debugging in Xcode

Screenshot 2019-10-24 at 11 10 07

@dpa99c dpa99c closed this as completed Oct 24, 2019
@dpa99c dpa99c added the Can't repro Unable to reproduce the issue as described label Oct 24, 2019
dpa99c pushed a commit that referenced this issue Nov 1, 2019
@dpa99c
Copy link
Owner

dpa99c commented Nov 1, 2019

Note: the above commit resolves this by ensuring the stacktrace appears in the "Stack trace" area of the Crashlytics console instead of in the "Keys" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can't repro Unable to reproduce the issue as described ios relates to iOS platform runtime issue An issue related to app runtime
Projects
None yet
Development

No branches or pull requests

3 participants