Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference between hasPermission result in Android and iOS #153

Closed
nvelin-zaggo opened this issue Sep 20, 2019 · 0 comments
Closed

Difference between hasPermission result in Android and iOS #153

nvelin-zaggo opened this issue Sep 20, 2019 · 0 comments
Labels
android Relates to Android platform bug Something isn't working properly legacy Related to inherited code/functionality runtime issue An issue related to app runtime

Comments

@nvelin-zaggo
Copy link

"On Android, returns true if remote notifications are enabled."
"callbackContext.success(areNotificationsEnabled ? 1 : 0);"

This statement is wrong, on Android, hasPermission return 1 or 0.
It will be better, if possible, to return directly areNotificationsEnabled in the callback to match the signature.
@dpa99c dpa99c added android Relates to Android platform legacy Related to inherited code/functionality runtime issue An issue related to app runtime labels Sep 30, 2019
@dpa99c dpa99c added the bug Something isn't working properly label Nov 7, 2019
@dpa99c dpa99c added the ready for release Something has been implemented and is awaiting release to npm label Nov 7, 2019
@dpa99c dpa99c closed this as completed in c4ade00 Nov 9, 2019
@dpa99c dpa99c removed the ready for release Something has been implemented and is awaiting release to npm label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Relates to Android platform bug Something isn't working properly legacy Related to inherited code/functionality runtime issue An issue related to app runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpa99c @nvelin-zaggo