Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Ensure $(inherited) flag is present in Xcode project build settings #25

Closed
dpa99c opened this issue Jul 1, 2019 · 5 comments
Closed
Labels
bug Something isn't working properly

Comments

@dpa99c
Copy link
Owner

dpa99c commented Jul 1, 2019

Currently an iOS build outputs this warning:

[!] The `FirebaseTest [Debug]` target overrides the `LD_RUNPATH_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-FirebaseTest/Pods-FirebaseTest.debug.xcconfig'. This can lead to problems with the CocoaPods installation

[!] The `FirebaseTest [Release]` target overrides the `LD_RUNPATH_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-FirebaseTest/Pods-FirebaseTest.release.xcconfig'. This can lead to problems with the CocoaPods installation

    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

This can lead to iOS build issues (see #22).

So the plugin hook scripts need to ensure the $(inherited) flag is present in the LD_RUNPATH_SEARCH_PATHS field of the Xcode project build settings.

@dpa99c dpa99c added the bug Something isn't working properly label Jul 1, 2019
@dpa99c dpa99c changed the title [iOS] Ensure `$(inherited) flag is present in Xcode project build settings [iOS] Ensure $(inherited) flag is present in Xcode project build settings Jul 1, 2019
@dpa99c dpa99c changed the title [iOS] Ensure $(inherited) flag is present in Xcode project build settings [iOS] Ensure $(inherited) flag is present in Xcode project build settings Jul 1, 2019
@dpa99c dpa99c closed this as completed in 2d86a26 Jul 1, 2019
@dpa99c
Copy link
Owner Author

dpa99c commented Jul 1, 2019

Fix published in cordova-plugin-firebasex@3.0.7

@sebastian-zarzycki-apzumi

FWIW I still see these warnings in 3.0.7.

@dpa99c
Copy link
Owner Author

dpa99c commented Jul 1, 2019

you will see the warnings on cordova platform add ios because that's before the after_prepare script has run.
But if you run cordova prepare ios or cordova build ios you won't see them, which is what matters.

@sebastian-zarzycki-apzumi

Ah. It's ok then, I guess. Thanks.

@consciousimages
Copy link

I actually see the warning in both places - cordova platform add ios as well as cordova build ios, using version 6.0.2.

tommy-hartz pushed a commit to tommy-hartz/cordova-plugin-firebasex that referenced this issue Nov 22, 2019
ewfian added a commit to leyserkids/cordova-plugin-firebase that referenced this issue Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

No branches or pull requests

3 participants