Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically enabled Sign in with Apple Entitlement causes xCode Error #511

Closed
4 of 5 tasks
EinfachHans opened this issue Sep 16, 2020 · 7 comments
Closed
4 of 5 tasks
Labels
bug Something isn't working properly build issue An issue related to build process ios relates to iOS platform

Comments

@EinfachHans
Copy link

Bug report

CHECKLIST

  • I have reproduced the issue using the example project or provided the necessary information to reproduce the issue.
  • I have checked that no similar issues (open or closed) already exist.

Current behavior:

Since your Change with #485 Sign in with Apple Entitlement is automatically added to the Project. For us not using SwA we get the Error: Provisioning profile "..." doesn't support the Sign in with Apple capability.

Expected behavior:

Maybe it is possible (with a script?) to only add this Entitlement if a specific Preference is set? (Or the other way, but like it's now, i think its kinda "breaking change" for everybody not using it.

@dpa99c dpa99c added bug Something isn't working properly build issue An issue related to build process ios relates to iOS platform TODO Something needs doing labels Sep 16, 2020
@dpa99c
Copy link
Owner

dpa99c commented Sep 16, 2020

Darn. OK, I think the best approach is to use a plugin variable to optionally set the Sign In with Apple capability in the Xcode entitlements. I'll see if I have time to push out a patch release later today with this functionality.

@Davedave2004
Copy link

I was also experiencing this, for now I just set it back to use the previous version. Good thing to know that somebody already opened an issue for this. 👍

@EinfachHans
Copy link
Author

@Davedave2004 If you want to use the other Features from Version 11.0.0, it's currently just one click to remove the Entitlement from xcode again 😊

@EinfachHans
Copy link
Author

@dpa99c I can create a PR to help you. What do you think about a logic similar to the one you use in the Diagnostics Plugin for enabling Modules? But here for kinda "Sections"? So we will only have this one for now, but maybe some others in the future? If we do so, do you prefer one Preference for all sections (like Diagnostic), or one preference for each section?

@dpa99c
Copy link
Owner

dpa99c commented Sep 16, 2020

@EinfachHans this plugin is already writing to various plists based on plugin variable values so I was just going to remove the <config-file> blocks from plugin.xml and write the values directly into the entitlement plists in JS using applyPluginVarsToPlists()

@dpa99c dpa99c closed this as completed in e7f9a0a Sep 16, 2020
@dpa99c
Copy link
Owner

dpa99c commented Sep 16, 2020

OK I've published a fix for this in cordova-plugin-firebasex@11.0.1.

This adds the plugin variable IOS_ENABLE_APPLE_SIGNIN (which defaults to false) but if it's set to true at plugin install time it will enable the Sign In with Apple capability in Xcode:

cordova plugin add cordova-plugin-firebasex --variable IOS_ENABLE_APPLE_SIGNIN=true

@dpa99c dpa99c removed the TODO Something needs doing label Sep 16, 2020
@EinfachHans
Copy link
Author

@dpa99c Thank you for your fast work 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly build issue An issue related to build process ios relates to iOS platform
Projects
None yet
Development

No branches or pull requests

3 participants