Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] stacktrace.js with logError #57

Closed
charpour opened this issue Jul 25, 2019 · 5 comments
Closed

[FEATURE] stacktrace.js with logError #57

charpour opened this issue Jul 25, 2019 · 5 comments
Labels
feature request New feature request

Comments

@charpour
Copy link

Hi,

Would it be possible to add something like this: https://github.com/wizpanda/cordova-plugin-firebase-lib/blob/master/src/android/FirebasePlugin.java#L552

It makes javascript error reporting so much easier, and it looks good on firebase crashlytics as well.

Thanks
@charpour
Copy link
Author

and here's the discussion around it: wizpanda#8

@dpa99c dpa99c changed the title stacktrace.js with logError [FEATURE] stacktrace.js with logError Jul 26, 2019
@dpa99c dpa99c added the feature request New feature request label Jul 26, 2019
@dpa99c
Copy link
Owner

dpa99c commented Jul 26, 2019

@sagrawal31 is this something you could look at bringing across from your repo?

@sagrawal31
Copy link
Collaborator

Sure, I'll do this.

sagrawal31 added a commit that referenced this issue Jul 26, 2019
@sagrawal31
Added ability to log JS stacktraces. #57 (Picked from https://github.…
e2e32fe 
…com/wizpanda/cordova-plugin-firebase-lib/pull/8/files)
@charpour
Copy link
Author

charpour commented Aug 2, 2019

Many thanks @sagrawal31 , appreciate it

@dpa99c
Copy link
Owner

dpa99c commented Aug 6, 2019

This has been released in v6.0.3

@dpa99c dpa99c closed this as completed Aug 6, 2019
@dpa99c dpa99c mentioned this issue Sep 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sagrawal31 @dpa99c @charpour