Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createChannel suggestion for multiple sounds #225

Merged
merged 2 commits into from
Apr 10, 2020
Merged

createChannel suggestion for multiple sounds #225

merged 2 commits into from
Apr 10, 2020

Conversation

markterrill
Copy link

@markterrill markterrill commented Nov 17, 2019 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

@ghost
Copy link

ghost commented Nov 17, 2019 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 0.003 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@dpa99c dpa99c merged commit b6ee144 into dpa99c:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markterrill @dpa99c