Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase upper bound on marshmallow-sqlalchemy #2191

Conversation

spike77453
Copy link
Contributor

Description

This increases the maximum allowed version of marshmallow-sqlalchemy to 0.28.x: marshmallow-sqlalchemy < 0.28.1 no longer works on Python 3.12 since it still uses distutils which was removed from Python (see PEP 632). This in turn means that Flask-AppBuilder currently doesn't work on Python 3.12 out of the box.

In marshmallow-sqlalchemy >= 0.28.1 distutils.version.LooseVersion was replaced with packaging.version.Version: marshmallow-code/marshmallow-sqlalchemy@1826a47

Similar changes have been previously submitted: #1905

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f00efc) 79.71% compared to head (ab88983) 79.71%.
Report is 3 commits behind head on master.

❗ Current head ab88983 differs from pull request most recent head 93e64cf. Consider uploading reports for the commit 93e64cf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2191   +/-   ##
=======================================
  Coverage   79.71%   79.71%           
=======================================
  Files          72       72           
  Lines        8990     8990           
=======================================
  Hits         7166     7166           
  Misses       1824     1824           
Flag Coverage Δ
python 79.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar self-requested a review February 9, 2024 09:26
@dpgaspar
Copy link
Owner

Thank you @spike77453

@dpgaspar dpgaspar merged commit f0fd560 into dpgaspar:master Feb 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants