From 30dc1b376eae34a3102ea63de5695d8a87503341 Mon Sep 17 00:00:00 2001 From: Tarun Pothulapati Date: Mon, 6 Mar 2023 22:26:49 +0530 Subject: [PATCH] chore(helm): Make release pipeline to update golden files Golden files need to be updated as version is updated in the `Chart.yaml` file. This commit adds the step to update the golden files in the release pipeline. To make that possible, The following additional changes are also required: - `Go.Work`: This adds support multi-module projects as we will have the tests along with the operator in sub-folders. This is required to run go cmds from the root directory. (like running tests in this case). - `.helmignore`: This updates the Helm chart to ignore the `/ci` folder during helm packaging as those are not required for users of the chart. --- .github/workflows/ci.yml | 3 +-- .github/workflows/docker-release.yml | 8 +++++++- contrib/charts/dragonfly/.helmignore | 4 ++++ go.work | 3 +++ 4 files changed, 15 insertions(+), 3 deletions(-) create mode 100644 go.work diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7b0dc27468ba..53e548e4cf1b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -101,8 +101,7 @@ jobs: - name: Chart Rendering Tests run: | - cd contrib/charts/dragonfly - go test -v ./... + go test -v ./contrib/charts/dragonfly/... - name: Set up chart-testing uses: helm/chart-testing-action@v2.3.1 diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml index ea7062931cae..e127e33abe86 100644 --- a/.github/workflows/docker-release.yml +++ b/.github/workflows/docker-release.yml @@ -70,6 +70,9 @@ jobs: - name: Install helm uses: azure/setup-helm@v3 + - name: Setup Go + uses: actions/setup-go@v3 + - name: Configure Git if: env.IS_PRERELEASE != 'true' run: | @@ -85,9 +88,12 @@ jobs: -e 's/^(appVersion\:) .*/\1 "'${{ env.TAG_NAME }}'"/g' \ contrib/charts/dragonfly/Chart.yaml + go test ./contrib/charts/dragonfly/... -update + git commit \ -m 'chore(helm-chart): update to ${{ env.TAG_NAME }}' \ - contrib/charts/dragonfly/Chart.yaml + contrib/charts/dragonfly/Chart.yaml \ + contrib/charts/dragonfly/ci - name: Push Helm chart as OCI to Github if: env.IS_PRERELEASE != 'true' diff --git a/contrib/charts/dragonfly/.helmignore b/contrib/charts/dragonfly/.helmignore index 0e8a0eb36f4c..095f37e704ab 100644 --- a/contrib/charts/dragonfly/.helmignore +++ b/contrib/charts/dragonfly/.helmignore @@ -21,3 +21,7 @@ .idea/ *.tmproj .vscode/ +ci/ +*.go +go.mod +go.sum diff --git a/go.work b/go.work new file mode 100644 index 000000000000..da3028d45b24 --- /dev/null +++ b/go.work @@ -0,0 +1,3 @@ +go 1.20 + +use ./contrib/charts/dragonfly