Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover the parser with tests #33

Open
drauf opened this issue Mar 11, 2021 · 1 comment
Open

Cover the parser with tests #33

drauf opened this issue Mar 11, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@drauf
Copy link
Owner

drauf commented Mar 11, 2021

Some options:

  • parse real files and treat the parser as a black-box
  • refactor some code and test particular methods
@drauf drauf added enhancement New feature or request good first issue Good for newcomers labels Mar 11, 2021
@drauf drauf changed the title Add test coverage to the parser Cover the parser with tests Mar 11, 2021
@drauf
Copy link
Owner Author

drauf commented May 30, 2023

This is now indirectly and very partially covered by #53
Proper tests would still be great, especially those that exercise various things that were problematic in the past, like top output differing between distros, usernames with spaces, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drauf