Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Int32ConstantEntry and NativeIntConstantEntry #228

Open
drcjt opened this issue May 15, 2023 · 0 comments
Open

Unify Int32ConstantEntry and NativeIntConstantEntry #228

drcjt opened this issue May 15, 2023 · 0 comments
Labels
refactoring Refactoring ideas

Comments

@drcjt
Copy link
Owner

drcjt commented May 15, 2023

Instead of having separate classes unify into a single class representing integral constants. The class can easily determine the vartype and exact size based on the actual integral constant itself.

This is kind of like this PR from the real dotnet - dotnet/runtime#85951 - but here we have 16 bit and 32 bit constants whereas PR 85951 is dealing with 32 and 64 bit constants respectively.

@drcjt drcjt added the refactoring Refactoring ideas label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring ideas
Projects
None yet
Development

No branches or pull requests

1 participant