Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide the header menu when there is no content in it #1331

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: hide the header menu when there is no content in it #1331

merged 2 commits into from
Feb 6, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Feb 3, 2024 •
edited
Loading

  • I am sure that the code is update-to-date with the dev branch.

@jikkai jikkai requested review from wzhudev and Jocs as code owners February 3, 2024 13:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (492f0e1) 29.53% compared to head (d8a858a) 29.53%.

Files Patch % Lines
...kages/ui/src/views/components/doc-bars/Toolbar.tsx 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1331      +/-   ##
==========================================
- Coverage   29.53%   29.53%   -0.01%     
==========================================
  Files         842      842              
  Lines       47849    47852       +3     
  Branches     9792     9795       +3     
==========================================
  Hits        14131    14131              
- Misses      33718    33721       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai requested a review from wzhudev February 5, 2024 02:26
@wzhudev wzhudev merged commit bf692c2 into dev Feb 6, 2024
7 checks passed
@wzhudev wzhudev deleted the feat/hide-header-menu branch February 6, 2024 00:43
Dushusir pushed a commit that referenced this pull request Feb 7, 2024
@jikkai @Dushusir
feat: hide the header menu when there is no content in it (#1331)
2a3c4b9 
* feat: hide the header menu when there is no content in it

* fix: remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@Jocs Jocs Jocs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jikkai @Jocs @wzhudev