Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): register sheet render extension #1356

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Feb 8, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

add facade apis for sheet render extension

  • registerSheetRowHeaderExtension
  • registerSheetColumnHeaderExtension
  • registerSheetMainExtension
  • remove unregister on RenderComponent

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 32.78%. Comparing base (b362e73) to head (f5b07ab).

Files Patch % Lines
packages/engine-render/src/components/component.ts 0.00% 6 Missing ⚠️
packages/facade/src/apis/facade.ts 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1356      +/-   ##
==========================================
+ Coverage   32.75%   32.78%   +0.03%     
==========================================
  Files         914      914              
  Lines       50776    50806      +30     
  Branches    10588    10590       +2     
==========================================
+ Hits        16630    16656      +26     
- Misses      34146    34150       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review February 19, 2024 03:55
packages/facade/src/apis/facade.ts Outdated Show resolved Hide resolved
packages/facade/src/apis/facade.ts Outdated Show resolved Hide resolved
packages/facade/src/apis/facade.ts Outdated Show resolved Hide resolved
@Dushusir Dushusir force-pushed the dushusir/facade-render-hook branch from 61cdedb to 063cca0 Compare March 4, 2024 12:21
@Dushusir Dushusir requested a review from wzhudev March 5, 2024 02:54
@Dushusir Dushusir force-pushed the dushusir/facade-render-hook branch 3 times, most recently from 53bda2e to aa9ff75 Compare March 7, 2024 11:58
@Dushusir Dushusir force-pushed the dushusir/facade-render-hook branch from aa9ff75 to 66c347b Compare March 8, 2024 03:12
@Dushusir Dushusir merged commit 264c097 into dev Mar 8, 2024
7 checks passed
@Dushusir Dushusir deleted the dushusir/facade-render-hook branch March 8, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants